d__k d__k - 4 months ago 36
Java Question

Spring Security authentication using UserDetailsService

I have some issues with Spring security authentication.
Everywhere in my application everything works great (CRUD operations work well), but login attempt fails.

Here's my code (I marked below with comments where userDAO is null which is cause of failed authentication):

@Service
public class UserServiceImpl implements UserService, UserDetailsService {

@Autowired
UserDAO userDAO;

@Override
public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException {
User user = userDAO.getUserByUsername(username); //userDAO == null Causing NPE
if (user == null)
throw new UsernameNotFoundException("Oops!");

List<SimpleGrantedAuthority> authorities = Arrays.asList(new SimpleGrantedAuthority(user.getRole()));

return new org.springframework.security.core.userdetails
.User(user.getLogin(), user.getPassword(), authorities);
}

@Override
public List<User> getUsers() {
return userDAO.getUsers();//userDAO !=null
}
//rest of code skipped


My SecurityConfig looks like this

@Configuration
@EnableWebMvcSecurity
@EnableGlobalMethodSecurity(prePostEnabled = true)
public class SecurityConfig extends WebSecurityConfigurerAdapter {

UserServiceImpl userService = new UserServiceImpl();

@Override
protected void configure(AuthenticationManagerBuilder auth) throws Exception {
auth.userDetailsService(userService);
}
//rest of code skipped


I marked where i get NPE and i have no idea how to solve this. Whole Configuration is JavaBased and you can check it out out here for more details
HERE

EDIT: getUsers() is invoked this way in controller:

@Controller
public class LoginController {
@Autowired
UserService userService;

@RequestMapping(value = "/dashboard")
public ModelAndView userDashboard(){
ModelAndView modelAndView = new ModelAndView("Dashboard");
List<User> userList = userService.getUsers();
modelAndView.addObject("users", userList);
return modelAndView;
}


And in this case (when invoking userService.getUsers()) userDAO is not null

Tried to fix it like Bohuslav Burghardt suggested and i got

method userDetailsService in class org.springframework.security.config.annotation.authentication.builders.AuthenticationManagerBuilder cannot be applied to given types;
required: T
found: com.gi.service.UserService
reason: inferred type does not conform to upper bound(s)
inferred: com.gi.service.UserService
upper bound(s): org.springframework.security.core.userdetails.UserDetailsService


in line
auth.userDetailsService(userService);

Answer

Problem solved with this piece of code from Bohuslav

public class SecurityConfig extends WebSecurityConfigurerAdapter {
    @Autowired
    private UserService userService;
}

Also missing

@ComponentScan("com.gi")

before

public class SecurityConfig extends WebSecurityConfigurerAdapter {

lack of which caused

Error:(24, 13) java: method userDetailsService in class org.springframework.security.config.annotation.authentication.builders.Authentic‌​ationManagerBuilder cannot be applied to given types; required: T found: com.gi.service.UserService reason: inferred type does not conform to upper bound(s) inferred: com.gi.service.UserService upper bound(s): org.springframework.security.core.userdetails.UserDetailsService