JohnC JohnC - 4 months ago 17
AngularJS Question

Angular bootstrap modal causing strict-di error, not sure why

Weird problem, using Angular UI bootstrap modal I have no issues at all with Angular 1.3 beta 16, however if I enable ng-strict-di mode I get the following error:

Error: [$injector:strictdi] function($scope, $modalInstance) is not using explicit annotation and cannot be invoked in strict mode
http://errors.angularjs.org/1.3.0-beta.16/$injector/strictdi?p0=function(%24scope%2C%20xmodalInstance)
at http://localhost:3000/vendor/angular.js:78:12
at annotate (http://localhost:3000/vendor/angular.js:3353:17)
at invoke (http://localhost:3000/vendor/angular.js:4037:21)
at Object.instantiate (http://localhost:3000/vendor/angular.js:4070:23)
at http://localhost:3000/vendor/angular.js:7451:28
at http://localhost:3000/vendor/ui-bootstrap-tpls-0.11.0.min.js:8:28715
at wrappedCallback (http://localhost:3000/vendor/angular.js:11616:81)
at http://localhost:3000/vendor/angular.js:11702:26
at Scope.$eval (http://localhost:3000/vendor/angular.js:12797:28)
at Scope.$digest (http://localhost:3000/vendor/angular.js:12609:31)


The weird thing is this is not in a directive or service, it's just the script behind one of my pages. I know I'm making a controller there but...well I'm not sure at this point. Here is the code that generated the error:

//=================
//MODAL PROMPTER
//=================

var Prompt = function(title, prompt) {
var modalInstance = $modal.open({
template: '<div class="modal-header"><h3 class="modal-title">' + title + '</h3></div><div class="modal-body"><p>' + prompt + '</p></div><div class="modal-footer"><button class="btn btn-primary" ng-click="ok()">OK</button><button class="btn btn-warning" ng-click="cancel()">Cancel</button></div>',
controller: ModalInstanceCtrl,
size: 'sm'

});

modalInstance.result.then(function(result) {
console.log('Modal OK');
}, function() {
console.log('Modal dismissed');
});
};

var ModalInstanceCtrl = function($scope, $modalInstance) {
$scope.ok = function() {
$modalInstance.close(true);
};
$scope.cancel = function() {
$modalInstance.dismiss(false);
};
};

//end of modal
//==================

//call it immediately to see the error
Prompt('myTitle', 'myMessage');


I'm not sure how or why I'm getting the error. If I turn off strict-di it works perfectly. Any ideas?

PSL PSL
Answer

You need to manually advertise your dependencies for the controller since you have ng-strict-di enabled.

function ModalInstanceCtrl ($scope, $modalInstance) { //or var ModalInstanceCtrl = function(...

  $scope.ok = function () {
    $modalInstance.close(true);
  };

  $scope.cancel = function () {
    $modalInstance.dismiss(false);
  };

};

ModalInstanceCtrl.$inject = ['$scope', '$modalInstance'];
Comments