Chenya Zhang Chenya Zhang - 3 months ago 33
Javascript Question

TypeError: callback.apply is not a function (Node.js & Mongodb)

When I add the line "{ upsert: true }", I got this error:

TypeError: callback.apply is not a function

// on routes that end in /users/competitorAnalysisTextData
// ----------------------------------------------------
router.route('/users/competitorAnalysisTextData/:userName')

// update the user info (accessed at PUT http://localhost:8080/api/users/competitorAnalysisTextData)
.post(function(req, res) {

// use our user model to find the user we want
User.findOne({ userName: req.params.userName}, function(err, user) {

if (err)
res.send(err);

console.log('user.competitorAnalysis.firstObservation: %@', user.competitorAnalysis.firstObservation);
// Got the user name
var userName = user.userName;
// update the text data
console.log('Baobao is here!');
user.update(
{
userName: userName
},
{ $set: { "competitorAnalysis.firstObservation" : req.body.firstObservation,
"competitorAnalysis.secondObservation" : req.body.secondObservation,
"competitorAnalysis.thirdObservation" : req.body.thirdObservation,
"competitorAnalysis.brandName" : req.body.brandName,
"competitorAnalysis.productCategory" : req.body.productCategory
} },
{ upsert: true }
);

// save the user
user.save(function(err) {
if (err)
return res.send(err);

return res.json({ message: 'User updated!' });
});

});
})


Without this line, there is no error. I'm new to nodejs, not very sure where the problem is.

Update

Still receive error message: "TypeError: callback.apply is not a function"

// on routes that end in /users/competitorAnalysisTextData
// ----------------------------------------------------
router.route('/users/competitorAnalysisTextData/:userName')

// update the user info (accessed at PUT http://localhost:8080/api/users/competitorAnalysisTextData)
.post(function(req, res) {

// Just give instruction to mongodb to find document, change it;
// then finally after mongodb is done, return the result/error as callback.
User.findOneAndUpdate({ userName : req.params.userName},
{
userName : req.params.userName
},
{ $set: {
"competitorAnalysis.firstObservation" : req.body.firstObservation,
"competitorAnalysis.secondObservation" : req.body.secondObservation,
"competitorAnalysis.thirdObservation" : req.body.thirdObservation,
"competitorAnalysis.brandName" : req.body.brandName,
"competitorAnalysis.productCategory" : req.body.productCategory
} },
{ upsert: true },
function(err, user) {
// after mongodb is done updating, you are receiving the updated file as callback

// now you can send the error or updated file to client
if (err)
res.send(err);

return res.json({ message: 'User updated!' });
});

})

Answer

There are 2 ways to update documents in mongodb:

  1. find the document, bring it to server, change it, then save it back to mongodb.

  2. just give instruction to mongodb to find document, change it; then finally after mongodb is done, return the result/error as callback.

In your code, you are mixing both methods.


  1. with user.save(), first you search the database with user.findOne, and pull it to server(nodejs), now it lives in your computer memory. then you can manually change the data and finally save it to mongodb with user.save()

    User.findOne({ userName: req.params.userName}, function(err, user) {

        if (err)
            res.send(err);
    
        //this user now lives in your memory, you can manually edit it
        user.username = "somename";
        user.competitorAnalysis.firstObservation = "somethingelse";
    
        // after you finish editing, you can save it to database or send it to client
         user.save(function(err) {
            if (err)
                return res.send(err);
    
            return res.json({ message: 'User updated!' });
        });
    
  2. the second one is to use User.findOneAndUpdate().. This is preferred, instead of user.findOne() then user.update(); because this is basically searching the database twice. One to find, and search again to update()

Anyway,the second method is telling mongodb to update the data without first bringing to server, Next, only after mongodb finish with its action, you will receive the updated-file (or error) as callback

User.findOneAndUpdate({ userName: req.params.userName}, 
            {
             userName: userName,
             $set: { "competitorAnalysis.firstObservation" : req.body.firstObservation,
                      "competitorAnalysis.secondObservation" : req.body.secondObservation,
                      "competitorAnalysis.thirdObservation" : req.body.thirdObservation,
                      "competitorAnalysis.brandName" : req.body.brandName,
                      "competitorAnalysis.productCategory" : req.body.productCategory
            } },
            { upsert: true },
        function(err, user) {
        //after mongodb is done updating, you are receiving the updated file as callback    

        // now you can send the error or updated file to client
        if (err)
            res.send(err);

        return res.json({ message: 'User updated!' });
        });