Sasa Sasa - 3 months ago 27
Javascript Question

modal in bootstrap navbar

I use modal from w3school, and it's works fine if I put button to call modal in body of page, but if I put button in bootstrap navbar dropdown it doesn't work. It's open modal but it's close immediately. Apparently modal is closing in same time as dropdown menu, but I don't know how.

Does anyone know solution for this problem?

<!DOCTYPE html>
<html>
<head>
<style>
/* The Modal (background) */
.modal {
display: none; /* Hidden by default */
position: fixed; /* Stay in place */
z-index: 1; /* Sit on top */
padding-top: 100px; /* Location of the box */
left: 0;
top: 0;
width: 100%; /* Full width */
height: 100%; /* Full height */
overflow: auto; /* Enable scroll if needed */
background-color: rgb(0,0,0); /* Fallback color */
background-color: rgba(0,0,0,0.4); /* Black w/ opacity */
}

/* Modal Content */
.modal-content {
background-color: #fefefe;
margin: auto;
padding: 20px;
border: 1px solid #888;
width: 80%;
}

/* The Close Button */
.close {
color: #aaaaaa;
float: right;
font-size: 28px;
font-weight: bold;
}

.close:hover,
.close:focus {
color: #000;
text-decoration: none;
cursor: pointer;
}
</style>
</head>
<body>

<h2>Modal Example</h2>

<div id="navbar" class="navbar-collapse collapse">
<ul class="nav navbar-nav navbar-right white nav-rlm">
<li class="dropdown">
<a class="dropdown-toggle" data-toggle="dropdown" href="#">
<i>Admin</i>
<i class="glyphicon glyphicon-user"></i>
<span class="caret"></span>
</a>
<ul class="dropdown-menu dropdown-user">
<li>
<a href="<?php echo base_url(''); ?>"><button id="myBtn">Open Modal</button><i class="glyphicon glyphicon-flag text-primary"></i> About</a>
</li>
</ul>
</li>
</ul>
</div>


<!-- The Modal -->
<div id="myModal" class="modal">

<!-- Modal content -->
<div class="modal-content">
<span class="close">×</span>
<p>Some text in the Modal..</p>
</div>

</div>

<script>
// Get the modal
var modal = document.getElementById('myModal');

// Get the button that opens the modal
var btn = document.getElementById("myBtn");

// Get the <span> element that closes the modal
var span = document.getElementsByClassName("close")[0];

// When the user clicks the button, open the modal
btn.onclick = function() {
modal.style.display = "block";
}

// When the user clicks on <span> (x), close the modal
span.onclick = function() {
modal.style.display = "none";
}

// When the user clicks anywhere outside of the modal, close it
window.onclick = function(event) {
if (event.target == modal) {
modal.style.display = "none";
}
}
</script>

</body>
</html>

Answer

The Open Modal <button> is inside an anchor element <a> which isn't valid HTML5 syntax:

<a href="<?php echo base_url(''); ?>">
    <button id="myBtn">Open Modal</button><i class="glyphicon glyphicon-flag text-primary"></i> About
</a>

That being said, you could change your JavaScript to:

// When the user clicks the button, open the modal
btn.onclick = function(e) {
    e.preventDefault();
    modal.style.display = "block";
}

To prevent the click event on the anchor from redirecting. However a better approach will be to remove the button altogether:

<ul class="dropdown-menu dropdown-user">
    <li>
        <a id="myBtn" href="<?php echo base_url(''); ?>"><i class="glyphicon glyphicon-flag text-primary"></i> About</a>
    </li>
</ul>

Here is a live example:
http://www.bootply.com/W8ESbhIkcd

Slightly off topic, have you considered using the built-in bootstrap modal?
http://getbootstrap.com/javascript/#modals