Byron Byron - 2 months ago 5
Python Question

how to simplify a try, if except code in python for repetitive input?

I used multiple if elif, also there are repetitive try, if, except command to eliminate negative, non-integer, non-number input, can I have a command that eliminate those ones altogether? Thanks! The code is as the following:

print("Welcome to Supermarket")
print("1. Potatoes($0.75 per potato)")
print("2. Tomatoes ($1.25 per tomato)")
print("3. Apples ($0.50 per apple)")
print("4. Mangoes ($1.75 per mango)")
print("5. checkout")

total = 0
i = 0
while i <= 0:
try:
choice = int(input("please enter 1, 2, 3, 4 or 5: "))
if choice not in (1, 2, 3, 4, 5):
raise ValueError()
except ValueError:
print("invalid input, you need to enter 1, 2, 3, 4 or5")
choice = -1
else:
if choice == 1:
try:
amount = int(input("how many potatoes do you want? "))
if amount < 0:
raise ValueError()
except ValueError:
print("invalid input")
else:
total = 0.75 * amount + total
cop = 0.75 * amount
print("the cost of potatoes is $", format(cop, ".2f"))
print("the total now is $", format(total, ".2f"))
elif choice == 2:
try:
amount = int(input("how many tomatoes do you want? "))
if amount < 0:
raise ValueError()
except ValueError:
print("invalid input")
else:
total = 1.25 * amount + total
cot = 1.25 * amount
print("the cost of tomatoes is $", format(cot, ".2f"))
print("the total now is $", format(total, ".2f"))
elif choice == 3:
try:
amount = int(input("how many apples do you want? "))
if amount < 0:
raise ValueError()
except ValueError:
print("invalid input")
else:
total = 0.5 * amount + total
coa = 0.5 * amount
print("the cost of apples is $", format(coa, ".2f"))
print("the total now is $", format(total, ".2f"))
elif choice == 4:
try:
amount = int(input("how many mangoes do you want? "))
if amount < 0:
raise ValueError()
except ValueError:
print("invalid input")
else:
total = 1.75 * amount + total
com = 1.75 * amount
print("the cost of mangoes is $", format(com, ".2f"))
print("the total now is $", format(total, ".2f"))
elif choice == 5:
print("your total is $", format(total, ".2f"))
choice = choice + 1
i = choice - 5

k = 0
while k < 1:
try:
insert = float(
input("enter you payment to the nearest cent(ex. 17.50 means you have entered 17 dollars and 50 cents): "))
if (insert - total) < 0:
raise ValueError()
except ValueError:
print(
"you must enter a number in the form like '17.50' and you have to enter an amount more than the total cost!")
k = k - 1
else:
change = insert - total
five_do = int(change / 5)
one_do = int(change % 5)
quart = int((change - five_do * 5 - one_do) / 0.25)
dime = int((change - five_do * 5 - one_do - quart * 0.25) / 0.1)
nickel = int((change - five_do * 5 - one_do - quart * 0.25 - dime * 0.1) / 0.05)
penny = (change - five_do * 5 - one_do - quart * 0.25 - dime * 0.1 - nickel * 0.05) * 100
print("total change is: $ ", format(change, ".2f"))
print("give customer: ", five_do, "$5 note,", one_do, "$1 note,",
quart, "quartz,", dime, "dimes,", nickel, "nickels,", format(penny, ".0f"), "pennies")

Answer

Extract the common validation code into it's own function:

def validate_input(input_message):
    """Validate that input is a positive integer"""
    amount = int(input(input_message))
    if amount < 0:
        raise ValueError("positive number required")
    return amount

Then call the function as needed:

if choice == 1:
    try:
        amount = validate_input("how many potatoes do you want? ")
    except ValueError:
        # do something with invalid input here
    else:
        # do something with valid input here

When you have this sort of repetition in your code it pays to see if there's a way to refactor it out into a function.