ghazyy ghazyy - 2 months ago 39
C# Question

best way to project ViewModel back into Model

Consider having ViewModel :

public class ViewModel
{
public int id {get;set;}
public int a {get;set;}
public int b {get;set;}
}


and a orginal Model like this :

public class Model
{
public int id {get;set;}
public int a {get;set;}
public int b {get;set;}
public int c {get;set;}
public virtual Object d {get;set;}
}


each time i get view model i have to put all ViewModel properties one by one into Model; something like :

var model = Db.Models.Find(viewModel.Id);
model.a = viewModel.a;
model.b = viewModel.b;
Db.SaveChanges();


which always cause lots of problem. i even sometimes forget to mention some properties and then disaster happens !
i was looking for somthing like :

Mapper.Map(model,viewModel);


BTW: i use automapper only to convert Model to ViewModel but in vise versa i always face errors.

Answer

Overall that might be not the answer, that you are looking for, but here's a quote from AutoMapper author:

I can’t for the life of me understand why I’d want to dump a DTO straight back in to a model object.

I believe best way to map from ViewModel to Entity is not to use AutoMapper for this. AutoMapper is a great tool to use for mapping objects without using any other classes other than static. Otherwise, code gets messier and messier with each added service, and at some point you won't be able to track what caused your field update, collection update, etc.

Specific issues often faced:

  1. Need for non-static classes to do mapping for your entities

    You might need to use DbContext to load and reference entities, you might also need other classes - some tool that does image upload to your file storage, some non-static class that does hashing/salt for password, etc etc... You either have to pass it somehow to automapper, inject or create inside AutoMapper profile, and both practices are pretty troublemaking.

  2. Possible need for multiple mappings over same ViewModel(Dto) -> Entity Pair

    You might need different mappings for same viewmodel-entity pair, based on if this entity is an aggregate, or not + based on if you need to reference this entity or reference and update. Overall this is solvable, but causes a lot of not-needed noise in code and is even harder to maintain.

  3. Really dirty code that's hard to maintain.

    This one is about automatic mapping for primitives (strings, integers, etc) and manual mapping references, transformed values, etc. Code will look really weird for automapper, you would have to define maps for properties (or not, if you prefer implicit automapper mapping - which is also destructive when paired with ORM) AND use AfterMap, BeforeMap, Conventions, ConstructUsing, etc.. for mapping other properties, which complicates stuff even more.

  4. Complex mappings

    When you have to do complex mappings, like mapping from 2+ source classes to 1 destination class, you will have to overcomplicate things even more, probably calling code like:

    var target = new Target();
    Mapper.Map(source1, target);
    Mapper.Map(source2, target);
    //etc..
    

    That code causes errors, because you cannot map source1 and source2 together, and mapping might depend on order of mapping source classes to target. And I'm not talking if you forget to do 1 mapping or if your maps have conflicting mappings over 1 property, overwriting each other.

These issues might seem small, but on several projects where I faced usage of automapping library for mapping ViewModel/Dto to Entity, it caused much more pain than if it was never used.

Here are some links for you:

Comments