y.safa y.safa - 7 months ago 17
Java Question

how to verify login input with database php MySQL

please help
i'm doing a loging activity for my android application, i checked the email and password with my database using this code

<?php


try
{
// On se connecte à MySQL
$bdd = new PDO('mysql:host=localhost;dbname=application;charset=utf8', 'root', '');

}
catch(Exception $e)
{

// En cas d'erreur, on affiche un message et on arrête tout
die('Erreur : '.$e->getMessage());
echo 'base de donnee n est pas connecte';
}



//Getting values
$username = $_POST['editusername'];
$password = $_POST['editpassword'];

//contact surgat
// On affiche chaque entrée une à une

$reponse = $bdd->query("SELECT * FROM personne WHERE Email='$username' AND Motpass='$password'");

while ($donnees = $reponse->fetch())

{
//if we got some result
if(isset($donnees)){
//displaying success
echo "success";

}else{
//displaying failure
echo "failure";
}

$reponse->closeCursor();
}
?>


and i'm working with android studio this is the loginactivity.java that i used in it AsyncTask to get the result

package com.example.yh.log;

import android.app.Activity;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.app.Dialog;
import android.app.ProgressDialog;
import android.content.Intent;
import android.os.AsyncTask;
import android.support.v7.app.ActionBarActivity;
import android.os.Bundle;
import android.util.Log;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.widget.Button;
import android.widget.EditText;
import android.widget.TextView;
import android.widget.Toast;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.io.UnsupportedEncodingException;
import java.net.HttpURLConnection;
import java.net.URL;
import java.util.ArrayList;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;

public class MainActivity extends Activity {
private EditText TextUserName;
private EditText TextPassword;
public static final String USER_NAME = "USERNAME";
String username;
String password;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);



}
public void onLoginClick(View view){

TextUserName = (EditText) findViewById(R.id.editusername);
TextPassword = (EditText) findViewById(R.id.editpassword);

username=TextUserName.getText().toString();
password=TextPassword.getText().toString();
if(username.isEmpty())
Toast.makeText(getBaseContext(),"Entrez votre username",Toast.LENGTH_SHORT).show();
else if(password.isEmpty())
Toast.makeText(getBaseContext(),"Entrez votre mot de passe",Toast.LENGTH_SHORT).show();
else {
String urlString = "http://192.168.173.1/Search/login.php";
LoginTask loginTask = new LoginTask();
loginTask.execute(urlString);
}
}
private class LoginTask extends AsyncTask<String,Void,String>
{
private Dialog loadingDialog;
@Override
protected void onPreExecute() {
super.onPreExecute();
loadingDialog = ProgressDialog.show(MainActivity.this, "Please wait", "Loading...");
}
@Override
protected String doInBackground(String... params) {
HttpURLConnection c=null;
try {
String urlString=params[0];
URL url=new URL(urlString);
c=(HttpURLConnection)url.openConnection();
c.setRequestMethod("POST");
c.setConnectTimeout(15000 /* milliseconds */);
c.setDoInput(true);
c.setDoOutput(true);
c.setRequestProperty("Content-Type", "application/x-www-form-urlencoded");
String s = "username="+username+"&password=" + password;

c.setFixedLengthStreamingMode(s.getBytes().length);
PrintWriter out = new PrintWriter(c.getOutputStream());
out.print(s);
out.close();

c.connect();
int mStatusCode = c.getResponseCode();
String result="";
switch (mStatusCode) {
case 200:
BufferedReader br = new BufferedReader(new InputStreamReader(c.getInputStream()));
StringBuilder sb = new StringBuilder();
String line;
while ((line = br.readLine()) != null) {
sb.append(line).append("\n");
}
br.close();
result = sb.toString();

}
return result;
} catch (Exception ex) {
Logger.getLogger(getClass().getName()).log(Level.SEVERE, null, ex);
return "Error connecting to server";
} finally {
if (c != null) {
try {
c.disconnect();
} catch (Exception ex) {
Logger.getLogger(getClass().getName()).log(Level.SEVERE, null, ex);
}
}
}
}
@Override
protected void onPostExecute(String s) {
//super.onPostExecute(s);
String ss = s;
loadingDialog.dismiss();
if(ss=="success") {
Intent intent = new Intent(MainActivity.this, UserProfile.class);
intent.putExtra(USER_NAME, username);
finish();
startActivity(intent);
}else{
Toast.makeText(getApplicationContext(), "invalide username or password", Toast.LENGTH_LONG).show();

}}
}
}


i keep geting this error in php code "indefined index editusername" when i run the activity and hit the button althought i declared the edit text with same ID in loginactivity.xml i have changed it many times but still not working

  <EditText android:id="@+id/editusername"
android:layout_width="match_parent"
android:layout_height="wrap_content" />


thank you.

Answer

The problem is that this in the Java:

 String s = "username="+username+"&password=" + password;

Doesn't match up with this in the PHP:

    //Getting values 
    $username = $_POST['editusername'];
    $password = $_POST['editpassword'];

Also note that you should use URLEncoder.encode() for values that come from user input:

String charset = "UTF-8";
String s = "editusername=" +
 URLEncoder.encode(username, charset) + 
 "&editpassword=" + 
 URLEncoder.encode(password, charset);

Also, you can't use == with Strings in Java, you need to use the equals() method:

@Override
protected void onPostExecute(String s) {
    //super.onPostExecute(s);
    String ss = s;
    loadingDialog.dismiss();

    //use equals() instead:
    if(ss.equals("success")) {
        Intent intent = new Intent(MainActivity.this, UserProfile.class);
        intent.putExtra(USER_NAME, username);
        finish();
        startActivity(intent);
    }else{
           Toast.makeText(getApplicationContext(), "invalide username or password", Toast.LENGTH_LONG).show();

    }}
}
Comments