chinds chinds - 2 months ago 30
React JSX Question

react this.props undefined or empty object

Building a small react app that passes the geoloaction (determined by the browser to a child component as props).

The first component: App.jsx

import React, {Component} from 'react';

import DateTime from './components/dateTime/_dateTime.jsx';
import Weather from './components/weather/_weather.jsx';
import Welcome from './components/welcome/_welcome.jsx';

require ('../sass/index.scss');

export default class App extends Component {

constructor() {
super();
this.state = {
latitude: '',
longitude: ''
};
this.showPosition = this.showPosition.bind(this);
}

startApp () {
this.getLocation();
}

getLocation() {
if (navigator.geolocation) {
navigator.geolocation.getCurrentPosition(this.showPosition);
} else {
console.log("Geolocation is not supported by this browser.");
}
}

showPosition(position) {
this.setState({
latitude: position.coords.latitude,
longitude: position.coords.longitude
})
}

componentWillMount () {
this.startApp();
}

render() {
return (
<div className="container">
<div className="header-container">
<Weather latitude={ this.state.latitude } longitude={ this.state.longitude } />
<DateTime />
</div>
<div className="welcome-container">
<Welcome name="Name" />
</div>
</div>
);
}
}


This component determines the location, saves the latitude and longitude to state and passes this information via props to the Weather.jsx component, which is working as you can see in the below image:

enter image description here

And in the weather.jsx component I try and access these props and gte either undefined or an empty object.

import React, {Component} from 'react';
import Fetch from 'react-fetch';

export default class Weather extends Component {

constructor(props) {
super(props);
this.state = {
forecast: {},
main: {},
weather: {},
};
this.setWeather = this.setWeather.bind(this);
}

getWeather (latitude, longitude) {
var self = this;

fetch('http://api.openweathermap.org/data/2.5/weather?lat=' + latitude + '&lon=' + longitude + '&units=metric&APPID=ed066f80b6580c11d8d0b2fb71691a2c')
.then (function (response) {
if (response.status !== 200) {
console.log('Looks like there was a problem. Status Code: ' + response.status);
return;
}

response.json().then(function(data) {
self.setWeather(data);
});
})

.catch (function (err) {
console.log('Fetch Error :-S', err);
});
}

setWeather (forecast) {
var main = forecast.main;
var weather = forecast.weather[0];

this.setState({
main: main,
weather: weather,
forecast: forecast
});
}

startApp () {
this.getWeather(this.props.latitude, this.props.longitude);
}

componentWillMount () {
this.startApp();
}

componentDidMount () {
// window.setInterval(function () {
// this.getWeather();
// }.bind(this), 1000);
}

render() {
return (
<div className="">
<div className="weather-data">
<span className="temp">{Math.round(this.state.main.temp)}&#176;</span>
<h2 className="description">{this.state.weather.description}</h2>
</div>
</div>
)
}
}


Really not sure what the issue is as the react dev tools shows that the weather component does indeed have the location set in the props which are passed down to that component.

Edit** Solved:

So the issue was that state is set asynronously and that my weather component was rendered before state was updated.

A simple check of the values within state during the render method solved the issue.

render() {

if (this.state.latitude != '' && this.state.longitude != '') {
var weatherComponent = <Weather latitude={ this.state.latitude } longitude={ this.state.longitude } />
} else {
var weatherComponent = null;
}

return (
<div className="container">
<div className="header-container">
{weatherComponent}
<DateTime />
</div>
<div className="welcome-container">
<Welcome name="Name" />
</div>
</div>
);
}

Answer

I believe the issue is as follows. SetState happens asynchronously. Because of this, your render function is firing before the latitude and longitude props have data. If you would have some if check before rendering your Weather component you would likely not have this issue. Here is an example of what I mean.

render() {
    let myComponent;
    if(check if props has val) {
        myComponent = <MyComponent />
    } else {
        myComponent = null
    }
    return (
        {myComponent}
    )
}