htellez htellez - 9 months ago 682
AngularJS Question

How to implement an ng-change for a custom directive

I have a directive with a template like

<div ng-repeat="item in items" ng-click="updateModel(item)">

My directive is declared as:

return {
templateUrl: '...',
restrict: 'E',
require: '^ngModel',
scope: {
items: '=',
ngModel: '=',
ngChange: '&'
link: function postLink(scope, element, attrs)
scope.updateModel = function(item)
scope.ngModel = item;

I would like to have ng-change called when an item is clicked and the value of foo has been changed already.

That is, if my directive is implemented as:

<my-directive items=items ng-model="foo" ng-change="bar(foo)"></my-directive>

I would expect to call bar when the value of foo has been updated.

With code given above, ngChange is successfully called, but it is called with the old value of foo instead of the new updated value.

One way to solve the problem is to call ngChange inside a timeout to execute it at some point in the future, when the value of foo has been already changed. But this solution make me loose control over the order in which things are supposed to be executed and I assume that there should be a more elegant solution.

I could also use a watcher over foo in the parent scope, but this solution doesn't really give an ngChange method to be implmented and I have been told that watchers are great memory consumers.

Is there a way to make ngChange be executed synchronously without a timeout or a watcher?



If you require ngModel you can just $setViewValue on ngModelController which implicitly evaluates ng-change. The fourth parameter to the linking function should be the ngModelCtrl. The following code will make ng-change work for your directive.

link : function(scope, element, attrs, ctrl){
    scope.updateModel = function(item) {

In order for your solution to work, please remove ngChange and ngModel from isolate scope of myDirective.

Here's a plunk: