gmmo gmmo - 5 months ago 29
Android Question

why use WeakReference on android Listeners?

I am working on a large code base, and see in many places this type of code:

public static class RequestCustomData implements View.OnClickListener {
WeakReference<MainActivity> mainActivity;

public RequestCustomData(MainActivity activity) {
mainActivity = new WeakReference<>(activity);

public void onClick(View view) {
MainActivity activity = mainActivity.get();
activity.requestCustomData(true, null);

I am a bit confused why this is used is so many places? I took a look at this document but it did not clarify well why this type of code is so heavily used on the app I am working on it

Anyone can explain me if this is a common pattern? If so, why?


A weak reference, simply put, is a reference that isn't strong enough to force an object to remain in memory.

The authors of this code most likely wanted to avoid leaking of the Activity context if the RequestCustomData object could outlive the Activity itself.

I recommend Romain Guy's post on this topic as well as several specific cases to avoid: