steve_gallagher steve_gallagher - 1 year ago 61
Ruby Question

Refactoring Ruby : Converting string array to int array

I'm refactoring a checkers program, and I am trying to process a players move request (in the form of "3, 3, 5, 5" for example) into an int array. I have the following method, but it doesn't feel as Ruby-like as I know it could be:

def translate_move_request_to_coordinates(move_request)
return_array = []
coords_array = move_request.chomp.split(',')
coords_array.each_with_index do |i, x|
return_array[x] = i.to_i

I have the following RSpec test with it.

it "translates a move request string into an array of coordinates" do
player_input = "3, 3, 5, 5"
translated_array = @game.translate_move_request_to_coordinates(player_input)
translated_array.should == [3, 3, 5, 5]

The test passes, but I think the code is pretty ugly. Any help would be appreciated. Thanks.


Answer Source

You could replace the explicit iteration of each by a map operation:

move_request.chomp.split(',').map { |x| x.to_i }

A more concise way of writing this as proposed by @tokland is :


It avoids explicitly writing a block and also choosing a variable name like x which is not relevant as any name would do.

Please have a look at stackoverflow post What does to_proc method mean?