user2925656 user2925656 - 1 month ago 12
Android Question

Android custom toolbar onOptionsItemSelected not working

I got two similar buttons

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="fill_parent"
android:layout_height="match_parent"
android:orientation="horizontal" >
<Button
android:id="@+id/sync_button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="Sync"
android:layout_alignParentEnd="true"
android:layout_alignParentRight="true"
/>

</RelativeLayout>


added as items to menu

<menu xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:android="http://schemas.android.com/apk/res/android">
<item
android:id="@+id/toggle_item"
android:title=""
app:showAsAction="always"
app:actionLayout="@layout/switch_button"
/>
<item
android:id="@+id/sync_item"
android:title=""
app:showAsAction="always"
app:actionLayout="@layout/sync"
/>
</menu>


I inflate items to menu in onCreateOptionsMenu with

getMenuInflater().inflate(R.menu.menu_main, menu);


Everything seems fine, but when i click in application, nothing happens as onOptionsItemSelected(MenuItem item) is never called

@Override
public boolean onOptionsItemSelected(MenuItem item) {
Integer test = item.getItemId();
switch (item.getItemId()) {
case R.id.toggle_item:
...
case R.id.sync_item:
...
return super.onOptionsItemSelected(item);
}


Adding toolbar with

Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
setSupportActionBar(toolbar);

Answer

I finally found the answer. Combination of these two answers solved my issue:

http://stackoverflow.com/a/17764895/2925656

http://stackoverflow.com/a/23936117/2925656

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    MenuInflater inflater = getMenuInflater();
    inflater.inflate(R.menu.main_menu, menu);
    final Menu m = menu;
    final MenuItem item = menu.findItem(R.id.sync_button);
    item.getActionView().setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View v) {   
            do_stuff;
        }
    });
    return true;
}

Menu item:

  <item
    android:id="@+id/myswitch"
    android:title=""
    app:showAsAction="always"
    app:actionLayout="@layout/toggle" />

Active layout must implement:

android:clickable="false"

My toggle action layout:

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="fill_parent"
android:layout_height="wrap_content"
android:clickable="false">
<ToggleButton
        android:id="@+id/actionbar_service_toggle"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:textOn="Discovery"
    android:textOff="Favourite"
    android:clickable="false"/>
</RelativeLayout>
Comments