datapanda datapanda - 2 years ago 118
AngularJS Question

Issue with Angular.js and Angular Style Guide

I'm having an issue correctly getting a data service to work as I try to follow the Angular Style Guide (

I'm sure it's something obvious to the more experienced but I can't get the data set to assign properly to the vm.items outside of the

Data Service

(function() {
'use strict';

.factory('portfolioService', portfolioService);

portfolioService.$inject = ['$http', 'logger'];

function portfolioService($http, logger) {

return {

getPortfolioData: getPortfolioData,


function getPortfolioData() {

return $http.get('./assets/portfolio/portfolioItems.json')

function getPortfolioDataComplete(response) {


function getPortfolioDataFail(error) {

logger.error('XHR Failed for getPortfolioData.' +;


.controller('portfolioController', ['$scope', '$http', '$stateParams', 'logger', 'portfolioService', function($scope, $http, $stateParams, logger, portfolioService) {

var vm = this;
vm.items = [];


function activate() {
return getData().then(function() {'Activate the portfolio view');


function getData() {
return portfolioService.getPortfolioData()
.then(function(data) {
vm.items = data;
return vm.items;



Answer Source

Your getData function is a promise, so it's run asynchronously. Your onsole.log are called before the end of the promise so the vm.items is still empty.

Try to put the log in the then callback.

Recommended from our users: Dynamic Network Monitoring from WhatsUp Gold from IPSwitch. Free Download