Alex Alex - 1 year ago 146
Objective-C Question

Calling reloadRowsAtIndexPaths removes tableView contentOffset

Whenever i call


My UITableView contentOffset is removed, is there a delegate method i can use to catch the table view updating and set the Offset again so that it remains in place and does not animate into view, or simply prevent it doing this?

I am setting the contentOffest in viewDidLoad:

self.tableView.contentOffset = CGPointMake(0, 43);

Here is an example usage:

[self.tableView reloadRowsAtIndexPaths:[NSArray arrayWithObjects:[params valueForKey:@"index"], nil] withRowAnimation:UITableViewRowAnimationFade];

Which removes the contentOffset and animates it into view, which i do not want.

More specifically this appears to occur when the row being reloaded is at indexPath.section 0 and indexPath.row 0, i.e the top row.

More Information

I am calling reloadRowsAtIndexPaths after an asynchronous request to fetch an image from a server. It basically works like so:

  • cellForRowAtIndexPath is called which checks for the presence of the thumb file on the disk, if the file is not present a placeholder is loaded in it's place and an asynchronous request is started in a background thread to fetch the image.

  • When the image download has completed i call
    for the correct cell so that the correct image fades in in place of the placeholder image.

  • The amount of cells may be different as the request is called inside cellForRowAtIndexPath so that the images load in as the cells load

cellForRowAtIndexPath file check

paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
path = [[paths objectAtIndex:0] stringByAppendingPathComponent:[NSString stringWithFormat:@"%@_small.gif",[[listItems objectAtIndex:indexPath.row] valueForKey:@"slug"]]];

if([[NSFileManager defaultManager] fileExistsAtPath:path]){

listCell.imageView.image = [UIImage imageWithData:[NSData dataWithContentsOfFile:path]];

} else {

listCell.imageView.image = [UIImage imageNamed:@"small_placeholder.gif"];

NSMutableDictionary *params = [[NSMutableDictionary alloc] initWithObjectsAndKeys:[[[listItems objectAtIndex:indexPath.row] valueForKey:@"image"] valueForKey:@"small"],@"image",[NSString stringWithFormat:@"%@_small.gif",[[listItems objectAtIndex:indexPath.row] valueForKey:@"slug"]], @"name",indexPath,@"index",@"listFileComplete",@"notification",nil];

[NSThread detachNewThreadSelector:@selector(loadImages:) toTarget:self withObject:params];

[params release];


File donwloaded notification:

-(void)fileComplete:(NSNotification *)notification {

[self performSelectorOnMainThread:@selector(reloadMainThread:) withObject:[notification userInfo] waitUntilDone:NO];

Cell reload ( i have hardcoded sections due to a bug with strange section numbers being passed very rarely causing a crash:

-(void)reloadMainThread:(NSDictionary *)params {

NSIndexPath *index;

switch ([[params valueForKey:@"index"] section]) {
case 0:
index = [NSIndexPath indexPathForRow:[[params valueForKey:@"index"] row] inSection:0];
[self.tableView reloadRowsAtIndexPaths:[NSArray arrayWithObjects:[params valueForKey:@"index"], nil] withRowAnimation:UITableViewRowAnimationNone];
index = [NSIndexPath indexPathForRow:[[params valueForKey:@"index"] row] inSection:2];
[self.tableView reloadRowsAtIndexPaths:[NSArray arrayWithObjects:index,nil] withRowAnimation:UITableViewRowAnimationFade];


Answer Source

EDIT: My original answer may not have focused on the core problem

Are you changing your number of rows before the call to reloadRows...? reloadRows... is specifically to animate a value change, so your code should look something like this:

UICell *cell = [self cellForRowAtIndexPath:indexPath];
cell.label.text = @"Something new";
[self.tableView reloadRowsAtIndexPaths:[NSArray arrayWithObject:indexPath] withRowAnimation:UITableViewRowAnimationFade]];

Is that more or less what you look like, but the tableview is forgetting where it is?

Previous discussion

You don't call -beginUpdates and -endUpdates around a reload. You call -beginUpdates and -endUpdates around your related modifications of the backing data, during which you should be calling -insertRowsAtIndexPaths:withRowAnimation: and its relatives. If you call the updating routines, then you don't need to call the reload routines. Reloading in the middle of an update is undefined behavior.

See Batch Insertion, Deletion, and Reloading of Rows and Sections for details on when you use -beginUpdates.