jesobremonte jesobremonte - 4 months ago 38
Android Question

RxJava with Presenter and retained fragment for configuration changes

I'm new to RxJava and using this together with MVP architecture.

I've found a few examples on saving observables upon configuration changes using a retained fragment(still not sure if this is the best way to do it). The examples I've found though is handling observables directly on the Activity or Fragment, not from a Presenter.

So I experimented and set up this quick example(using only Reactivex's RxJava and RxAndroid lib) just to test, which seems to work fine. What this example does is:


  1. Initiates an activity with a headless retained fragment.

  2. Push button

  3. Presenter calls a FakeService for a delayed(5seconds) response observable.

  4. Presenter does .cache() on this observable.

  5. Presenter tells the view to retain this observable.

  6. View saves the observable in a retained fragment.

  7. Presenter subscribes to observable.

  8. User does a configuration change(device rotation). User can do this as many times as he wants.

  9. OnPause tells the Presenter's CompositeSubscription to clear and unsubscribes from all current subscriptions.

  10. Activity gets recreated and reuses the existing retained fragment.

  11. Activity's onResume checks if the retained fragment's stored observable is null.

  12. If not null, tells the Presenter to subscribe to it.

  13. The retained observable gets subscribed to, and because .cache was called, it just replays the result to the new subscriber without calling the service again.

  14. When the Presenter shows the final result to the view, it also sets the retained fragment's saved observable to null.



I'm wondering if I'm doing this properly, and if there's a more efficient or elegant way to handle configuration change when the observable's subscription is being handled in a Presenter?




Edit:
Thanks for the feedback.
Based on this I've reached what I think is a cleaner solution, and I've updated my linked example with the changes.

With the new change; instead of passing the Observable from the Presenter to the Activity to the retainedFragment to be stored incase of a configurationChange event, I rather set the retainedFragment as a second "view" to the Presenter when it's created.

This way when onResume() happens after device rotation, I don't need to make the Activity do the ugly plumbing of passing the Observable from the retainedFragment back to the Presenter.

The Presenter can just interact with this second "view" directly and check for the retained observable itself and resubscribe if needed. The main Activity no longer needs to know about this observable. Suddenly it's a much simpler view layer.

Answer

Sounds about right, good job! Some suggestions:

  • You could just use Activity.onRetainNonConfigurationInstance(). I've heard it's getting un-deprecated in Android N. You can continue to use retained fragment if you like it, there's no problem with that, but you don't have to if you preferred not to use fragments.
  • Why only retain the observable and not the whole presenter? It seems maybe a bit wasteful to create a new presenter, maybe you can make it work with same instance that can "attach" and "detach" a view. But then again you have to deal with what to do if your observable emits while you are detached from any views, so maybe that's good enough.
  • Dan Lew recently made a case in his Droidcond SF talk that you shouldn't use cache(). He says replay() gives you greater control over what's happening and replay().autoconnect() works the same as cache(). He convinced me, but see for yourself.
Comments