Razem Ponad-kilo Razem Ponad-kilo - 8 months ago 29
C# Question

Inject object to the constructor of controller using unity container

I couldn’t find any similar issue so I’m writing this post. There is sample controller with private field IBaseClass. Sample code looks like follows:

public class TmpController : Controller
{
private IBaseClass _baseClass;

public TmpController()
{
_baseClass = new BaseClass(this);
}
}

public interface IBaseClass
{
//...
}

public class BaseClass : IBaseClass
{
protected TmpController TmpController;

public BaseClass(TmpController tmpController)
{
TmpController = tmpController;
}

//IBaseClass implementation
}


My question is; how to inject BaseClass object to the constructor of TmpController using Unity framework?
I want to make my controller "slimmer". I want to put the logic about validation and preparing dataSource of my controls like comboBox etc. to different class. I try to make some kind of SOC in my .Web project in that very specific case, which will make my controller easier to read and maintain. I'm using approach one controller per one view but I met the case with very complex form. Currently I have controller with more than 3000 lines of code and it's hard to maintain so I want to do something with it.
And yes I'm using Services and Repositories but the problem is about validation of ViewModels, mapping ViewModel objects into DTOs and backwards, preparing data source of given components etc.

Answer Source

@Razem, what you guess from my comment is correct. And the minus point you described is also valid.

What you are asking "Service depending on the controller" can surely be achieved but that would be a bad design.

Currently BaseClass is only dependent on TempController. How would you handle the scenario when you need the BaseClass in some other controller also? The code will start breaking and you will end up adding new dependency to BaseClass.

Also as per the design recommendations Top Layers should be dependent on the Bottom Layers not the vice versa.

Being said that, you can still achieve the feature you are looking for that too by making controller dependent on the IBaseClass.

I am not sure the specific reasons you need to access controller inside BaseClass. I have made certain assumptions while creating following suggestions. One of such assumption is BaseClass, IBaseClass and Controller classes are part of the same assembly.

//Have a BaseController Class with the properties and/or method which you will be using in the `BaseClass` class and make them virtual so that derived controller classes can override them to have specific implementation.

public class BaseController : Controller
{
    public virtual string ControllerMethod()
    {
        return "Controller Method from Base Controller";
    }

    public virtual string RandomValue
    {
        get
        {
            return "Random value from Base Controller";
        }
    }
}

Create a method in IBaseClass which will Set the Controller for it.

public interface IBaseClass
{
    void SetController(BaseController controller);

    void Method1();
}

public class BaseClass : IBaseClass
{
    private BaseController controller;
    public void SetController(BaseController controller)
    {
        this.controller = controller;
    }

    public void Method1()
    {
        var str = this.controller.RandomValue;
    }
}

And derive the TempController from the BaseController and make it dependent on IBaseClass. And in the constructor of TempController call SetController method of IBaseClass by passing this argument to it. You also can override method/properties of BaseController here.

After this you can call any method of IBaseClass without passing controller instance to it.

public class TempController : BaseController
{
    private IBaseClass baseClass;
    public HomeController(IBaseClass productService)
    {
        this.baseClass = productService;
        this.baseClass.SetController(this);
    }

    public override string RandomValue
    {
        get
        {
            return "Random value from Derived Class.";
        }
    }

    public ActionResult Index()
    {
        this.baseClass.Method1();

        ViewBag.Title = "Home Page";

        return View();
    }
}

Install nuget package Unit.Mvc in your web project. Open file Unity.Config located under App_Start folder and change method RegisterTypes as following.

public static void RegisterTypes(IUnityContainer container)
{
   container.RegisterType<IBaseClass, BaseClass>(new PerRequestLifetimeManager());
}

I am sure I don't need to explain how this is going to work.

P.S. : You need to make sure that you calls IBaseClass.SetController method in controller constructor to avoid NullReferenceException when you use controller in BaseClass. This is small overhead you need to take to achieve good and maintainable design.